search

newcastleuniversity / puppet_module_microsoft_defender_atp_agent

Adapted from https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/linux-install-with-puppet
0 stars 0 forks source link

Cannot alter sources file name #8

Open threepistons opened 1 year ago

threepistons commented 1 year ago

The cloud-init files used by our build system and this module both try to add the source for mdatp, but with different names. I can resolve this conflict by parameterising the name of the sources file in the module so that I can set the sources file name in the control repo to match the build system, without altering the default behaviour of this module for anyone else who might use it.

The workflow for this task looks like:

  1. [x] I will raise an issue against the mdatp module,
  2. [x] I add the parameterisation feature,
  3. [ ] I tag a new release.
  4. [ ] I alter the controlrepo:
    • [ ] bump the mdatp module version used in the control repo,
    • [ ] set the parameterised source name in Hiera, and
    • [ ] add a file resource to remove the old sources file.

The kind of output I see from Apt is

W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/microsoft.list:1 and /etc/apt/sources.list.d/microsoftpackages.list:3
threepistons commented 2 months ago

Feature added in 1fd86d1 but not yet tagged for release. I also altered the build system to prevent the conflict in a rather more immediate way, see https://github.com/newcastleuniversity/nuit-linux-imaging/commit/80ee4d51ba70715361960969f231d9b8607e41ca