search

newcat / baklavajs

Graph / node editor in the browser using VueJS
http://baklava.tech
MIT License
1.6k stars 117 forks source link

Add named export for getDomElements #433

Closed Doltario closed 2 weeks ago

Doltario commented 3 weeks ago

So that the method is accessible from the outside, at least useful to fully customize ConnectionWrapper.

Also, kept it as default to not break anything.

It completes work done in https://github.com/newcat/baklavajs/issues/408.

Really tiny PR but I felt bad only commenting issues. Also it made me pretty sure I don't mess with anything ^^ If you want to do it your way, feel free to take or rework that change !

PS: I prepared changes to delete default export inside domResolver, to have only named exports. If you think it would be better, let me know so that I can push it.

newcat commented 3 weeks ago

Thank you! Feel free to push the change with named exports; I usually only use named exports that's also why I didn't check it when I added the export in the index.ts file.

Doltario commented 3 weeks ago

Hey, it is pushed !

I ran yarn test and tried temporary connection through yarn playground. Everything seems fine, I don't know if there is more to do in the process.