newfold-labs / how-we-work

https://newfold-labs.github.io/how-we-work/
0 stars 0 forks source link

Add repository branch preference to forks for the sake of workflows #23

Closed circlecube closed 8 months ago

circlecube commented 8 months ago

Proposed changes

Noticed that a lot of PRs lately in plugins originate from forked repos. The issue with this is the workflows (cypress cloud and builds) check that the repo is the org owned repo, so unless we want to change them, a PR from a forked repo will not run the build step. Thus impossible to get a zip to manually test.

I am not 100% clear on permissions and team management in github, so if the reason for these forks is because they don't have access and we can't give them this access, I think we could update the workflows to work in all cases, or at least the build step. Otherwise, we can set an expectation that branches are preferred over forks.

We should also publicize a uniform branch naming convention among all teams so things are kept neat.

Type of Change

Checklist

Further comments