search

newfold-labs / wp-module-ecommerce

Next-generation eCommerce Experience for WordPress sites at Newfold Digital.
GNU General Public License v2.0
9 stars 3 forks source link

Fix Launch button error #128

Closed circlecube closed 1 year ago

circlecube commented 1 year ago

I'm seeing a js error in the console when the Launch button is clicked.

Uncaught (in promise) ReferenceError: RuntimeSdk is not defined

This was found in prepping HostGator for next release, but I also checked and found this issue in the latest public bluehost plugin too. The error displays once the launch button is clicked, and it does fire the launch event properly but the notice doesn't display. The error is when it tries to getTitle for the notification.

I've added the import for the RuntimeSdk.

Warning: I only assume this will fix it but have not done a complete build and test. Let's make sure to test locally before merging.

circlecube commented 1 year ago

Closing this PR since this was fixed elsewhere: https://github.com/newfold-labs/wp-module-ecommerce/commit/e0d1e25a99b7d0d0e3351c3f1cb6d853ddbc1123