search

newfold-labs / wp-module-ecommerce

Next-generation eCommerce Experience for WordPress sites at Newfold Digital.
GNU General Public License v2.0
9 stars 3 forks source link

Fix nesting issue #172

Closed circlecube closed 11 months ago

circlecube commented 11 months ago

This <p> element contains an <Alert> element. The <Alert> loads a <div>. I'm seeing a warning from react on it.

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.

https://github.com/newfold-labs/wp-module-ecommerce/blob/dc87a1feae60dc0b5df0795ded184a5bc859131b/src/components/OnboardingScreen.js#L72C17-L72C17

I was seeing this react warning locally and it took a while to track it down to this component. Can we update the <p> parent to a <div>?

circlecube commented 11 months ago

https://jira.newfold.com/browse/PRESS4-419

aratidgr8 commented 11 months ago

This has been fixed by @manikantakailasa in release version 1.3.10