newfold-labs / wp-module-ecommerce

Next-generation eCommerce Experience for WordPress sites at Newfold Digital.
GNU General Public License v2.0
5 stars 3 forks source link

Move site preview section out of Ecommerce module. #283

Open aratidgr8 opened 3 months ago

aratidgr8 commented 3 months ago

Is your feature request related to a problem? Please describe. Currently on Home page of brand plugin we display

This section is implemented in src/components/OnboardingScreen.js component in Ecommerce Module.

As per module responsibilities guidelines this section should not be a primary concern of wp-module-ecommerce and needs to be handled separately.

Screenshot 2024-04-15 at 5 11 14 PM

Describe the solution you'd like Move this functionality out of Ecommerce module.

Describe alternatives you've considered

Additional context

aratidgr8 commented 3 months ago

@wpscholar Please confirm if site preview section should be a separate module itself or it should be moved to any of existing newfold-labs modules like wp-module-coming-soon etc.

wpscholar commented 3 months ago

@aratidgr8 I think it probably makes sense to have a wp-module-homepage module that handles anything specific to the homepage. We'd use slot-fill to ensure that the Coming Soon module can handle the site/store launch, etc.