Bugfix: Empty script being loaded from the e-commerce module - Githubissues

newfold-labs / wp-module-ecommerce

Next-generation eCommerce Experience for WordPress sites at Newfold Digital.

GNU General Public License v2.0

10 stars 4 forks source link

Bugfix: Empty script being loaded from the e-commerce module #348

Closed aratidgr8 closed 2 months ago

aratidgr8 commented 2 months ago

Proposed changes

PRESS0-1968 : The Ecommerce module is loading the root plugin directory as a script. JIRA: https://jira.newfold.com/browse/PRESS0-1968

Removed

\wp_register_script(
  'nfd-ecommerce-dependency',
  NFD_ECOMMERCE_PLUGIN_URL,
  array_merge( $asset['dependencies'], array() ),
  $asset['version']
);

Instead registered, 'vendor/newfold-labs/wp-module-ecommerce/build/index.js' file.

Type of Change

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Video

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have viewed my change in a web-browser
[ ] Linting and tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments