Changing admin_init hook to init as it is not firing the promotions tab in side menu

ramyakrishnai commented 4 weeks ago

Proposed changes

Type of Change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Video

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have viewed my change in a web-browser
[ ] Linting and tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

wpscholar commented 4 weeks ago

@ramyakrishnai - Just following up here. @BrianHenryIE mentioned that the init hook feels like the wrong hook, and admin_init feels more correct, given it automatically only applies in the backend context. I agree, but the issue is that the admin_menu hook fires before the admin_init hook (see https://developer.wordpress.org/apis/hooks/action-reference/). There doesn't seem to be a better hook that only applies to the admin area, so the solution you presented here is probably the best course of action.

wpscholar commented 4 weeks ago

This is the problem code here: https://github.com/newfold-labs/wp-module-ecommerce/blob/2e8bbee24011829b6ffb6e7c349fc1eab4c8f950/includes/ECommerce.php#L639

newfold-labs / wp-module-ecommerce