search

newfrac / fenicsx-fracture

FEniCSx Fracture mechanics examples
https://newfrac.github.io/fenicsx-fracture/
MIT License
24 stars 5 forks source link

Conflicting text description and implementation on LinearElasticity #5

Closed simo-11 closed 1 year ago

simo-11 commented 1 year ago

In picture and text it is said that second boundary condition is to block the horizontal component on the right boundary. In implementation second boundary condition is applied on top and is resulting picture shows that on right boundary there is horizontal displacement.

simo-11 commented 1 year ago

Correct implementation is available at https://github.com/newfrac/fenicsx-fracture/blob/main/notebooks/utils/elastic_solver.py

cmaurini commented 1 year ago

Thanks a lot for reporting. I think it is fixed now.

simo-11 commented 1 year ago

Pages give now 404 (not found). Possible pages are regenerated right now but this should be checked at some time. https://newfrac.github.io/fenicsx-fracture/notebooks/linear-elasticity/00-Mesh.html https://newfrac.github.io/fenicsx-fracture/notebooks/linear-elasticity/01-LinearElasticity.html

build-book action seems to have failed https://github.com/newfrac/fenicsx-fracture/actions/runs/6207972575/job/16853674496

cmaurini commented 1 year ago

... due to pyvista which is extremely fragile and different in linux and macosx... It is tested, just I should have done a merge request.

Any contribution will be appreciated. Do not hesitate to propose merge request for fixing issues or improve the examples.

Best,

Corrado