newfs / gobotany-app

Deployable code for the Go Botany application
9 stars 8 forks source link

Level 3: JS errors, page load sometimes incomplete #113

Closed jnga closed 12 years ago

jnga commented 12 years ago

On Level 3 pages, JS errors sometimes appear and the page does not always fully load. (Ember branch)

On Chrome, the following appears sometimes, most notably when returning to the Level 3 page after having visited a species page:

Uncaught TypeError: Cannot call method 'compute' of undefined results.js:105

In Firefox, when browsing to a Level 3 page (such as Woody Angiosperms or Non-thalloid Aquatics), often get this error, after which the image thumbnails can be blank:

App3.filter_controller is undefined var other_taxa = App3.filter_controller.compute(filter); results.js line 105

In Safari on Mac OS X, some JS errors appear and the page does not always fully load. Typically both of the errors below appear, but sometimes just the first one does:

jrrickerson commented 12 years ago

Seeing these issues during branch integration. I've put the specific places in results.js that reference the filter_controller behind the filter_controller_is_built Deferred that Brandon created.

jnga commented 12 years ago

So far this issue seems fixed with commit 408bcfd.