search

newfs / gobotany-app

Deployable code for the Go Botany application
9 stars 8 forks source link

Enable the full key #161

Closed sidkoul closed 12 years ago

sidkoul commented 12 years ago

The botanists would like to see how well the simple key method scales to the entire set of 3,200 plants. Enable this feature in an experimental branch that we can deploy and test without effecting the master branch.

brandon-rhodes commented 12 years ago

Per a discussion with Sid this afternoon, this will involving moving the 2nd and 3rd level pages beneath /simple/ as well.

brandon-rhodes commented 12 years ago

Sid, I have assigned this back to you so that you — and possibly then the botanists — can try this out, and let us know whether to merge this back to master as the basis of our approach towards the full key.

sidkoul commented 12 years ago

I've deployed the fullkey branch. I don't believe the species counts are correct. Compare the following:

http://stark-warrior-2258.herokuapp.com/full/woody-plants/woody-angiosperms/ http://stark-warrior-2258.herokuapp.com/simple/woody-plants/woody-angiosperms/

Are you seeing this as well, or have I munged the deploy?

brandon-rhodes commented 12 years ago

It looks like the compiled JavaScript file that runs in production is out-of-date on the branch. The file is:

/static/build/deploy/gobotany.application.js

I have run "jsbuild.sh" in gobotany-deploy and can confirm that I get the correct species count now, even with production-mode turned "on" here on my laptop. I will commit this new "gobotany.application.js" file and reference this issue from the commit message!

brandon-rhodes commented 12 years ago

I am re-opening this issue because, I just realized, this issue is about what we think of the Full Key as a feature — it's not simply about the little wrong-displayed-count problem that I just offered the patch for!

brandon-rhodes commented 12 years ago

I am closing this "big issue" since the full key merge has now landed. Specific problems and enhancements should be opened as new, separate issues.