Questions about models

[brandon-rhodes]

In the comments below I will produce a numbered list of questions about models for Sid and I to try to get answered — these are questions arising from #334 as it leads me back through all of our models via the admin interface.

[brandon-rhodes]

• Model GlossaryTerm
  • Field question_text is always empty and should be removed.
  • Field hint is always empty and should be removed.
• Model Pile
  • Method simplekey_species() is unused and can be removed.
• Model PileGroup
  • Field description
• Model ContentImage
  • Field description is always empty — remove?
• Model Taxon
  • Field distribution is not relational — we should ask John if we should fix.
  • Field invasive_in_states is not relational, like distribution.
  • Field sale_prohibited_in_states is not relational; again, might not be important?

[brandon-rhodes]

Also, see related issues:

347

[jnga]

Thanks for going over all this and asking for comments, Brandon. Yes, it looks like all those things in GlossaryTerm, Pile, and ContentImage should be removed.

As for Taxon, those three fields should be removed too. Evidently they are used during import for building the conservation statuses, but not used for the site. All the information they contain ends up in the conservation statuses, the model of which is a good and flexible way of managing this sort of region-based data. To remove the three fields, the importer would have to be changed to refer to taxa.csv for that data instead of the fields, which are already loaded by the time the importer gets to that point. Nevertheless, removing those fields should finish cleaning up that model nicely.

[brandon-rhodes]

Thanks for the sanity-check, John! And Merry Christmas.