search

newfs / gobotany-app

Deployable code for the Go Botany application
9 stars 8 forks source link

iPad: Plant preview popup can appear off screen #90

Closed sidkoul closed 12 years ago

sidkoul commented 12 years ago

On the third pile page, choosing a species at the bottom of the page results in the plant preview popup appearing off screen. The user needs to scroll to the top of the page to view the plant preview popup.

jnga commented 12 years ago

Could not reproduce this. On iPad 3 went to Woody Angiosperms Level 3 page. Activating plant preview popups throughout the page including at the very bottom worked as expected: the popup lightbox appears on the screen. Tried both local/dev code and the live server.

sidkoul commented 12 years ago

Wow. We thought it was bad enough having to deal with IE workarounds! I had no idea that there would be these kind of differences across Apple devices.

I can reproduce on an iPad 2 running iOS 4.3.5. The problem is more generalized -- anytime the user is viewing content below the fold, lightbox items are shown above the fold. The user has to know to scroll to the top of the screen to view the content. Happend with youtube videos, plant preview popups, and pile images. (e.g. scroll to the bottom of the first level id page and view the fern images).

jnga commented 12 years ago

Attempt to resolve with commit 8648251ed8: On iPad with iOS < 5, the page now always scrolls to the top when opening a lightbox. On iPad with iOS 5, the page only scrolls to the top when opening a video, where lightboxes do appear regardless of scroll position but videos do not play unless scrolled to the top.

jnga commented 12 years ago

After Sid reported similar issue on iOS 4.x on iPhone, also applied these fixes to other iOS devices (commit 2794475517).