newhinton / Round-Sync

An android cloud file manager, powered by rclone. Visit https://roundsync.com for more information!
https://roundsync.com
GNU General Public License v3.0
1.29k stars 51 forks source link

Add support for Base32768 encoding in crypt backend #101

Closed rmkjr closed 1 year ago

rmkjr commented 1 year ago

Pre-Submission checklist

What version of extRact are you using (About -> App version)?

2.1.1

What problem are you trying to solve?

Base32768 encoding support was added to rclone 1.58.0. When adding a crypt with existing encrypted content that is encoded in Base32768 extRact says "This folder is empty". Even thought v2.1.1 shows rclone's version as v1.61.1-rcx, it seems as though Base32768 (possibly Base64 too though I have not tested this) support is missing or not implemented in the configuration creator.

Edit: this does work if I manually add "filename_encoding = base32768" to the rclone.conf and import/overwrite extRact's config, so this likely just need to be added to the crypt's config gui.

newhinton commented 1 year ago

Regarding your edit: That is precisely the case.

I will not make any changes to the current config-setup gui.

The reason for this is that i am currently completely rewriting the setup, so that all config-options are automatically shown. The progress for that is here: #82

The linked pr will fix it, but it might take a bit. But your workaround works fine, and for all the other options aswell ;)

pesaventofilippo commented 1 year ago

I think there are still problems with this in the latest release. I manually added filename_encoding = base32768 to the config file, and uploading a file works, because it gets named similarly to other files I upload from my PC. The problem is the app can still only see files that are uploaded with the app itself, and not the ones uploaded from other instances of rclone. (yes, the password and salt are the same between my devices)