newhinton / Round-Sync

An android cloud file manager, powered by rclone. Visit https://roundsync.com for more information!
https://roundsync.com
GNU General Public License v3.0
1.3k stars 51 forks source link

Triggers not being removed #174

Open alensiljak opened 1 year ago

alensiljak commented 1 year ago

What version of Round Sync are you using (About -> App version)?

2.4.2-beta

What is your Android version, phone model and manufacturer?

Pixel 7, Lineage OS

Which steps are required to reproduce this issue?

Example:

  1. Create a task to sync a folder
  2. Create a trigger to run the task, once a day
  3. Delete the trigger
  4. Create the same trigger
  5. When the trigger fires, it will run the task twice
  6. If it is deleted and recreated again, it will run the task three times (or at least show the message that it was run three times)

Seems like the Android timers (or whatever scheduling is used) do not get removed when the triggers are deleted.

Please also enable rclone logging (Settings > Logging > Log Rclone errors). You're going to need the log for the last question.

What is your configuration (rclone.conf)?

N/A

Does the same issue also occur when using the same configuration on a PC or in Termux?

Did not try as there are no triggers.

newhinton commented 1 year ago

You are using the 2.4.2 beta, can you confirm that the task you tried to run was not canceled by you at an earlier point? Does the task run for longer than exactly 10 minutes?

alensiljak commented 1 year ago

Hi! Right now I get three executions per run. When it was happening twice I did not realise what was going on. It is possible that I cancelled it at some point. Perhaps there was a network issue, or something like that. The second time I wanted to change either the name or the time and the task started to run three times per trigger. So, that second time I did not cancel any tasks.

As for the duration, the task usually runs for a couple of seconds at most as it only transfers one file, which is less than a Megabyte large.

newhinton commented 1 year ago

There were some issues with 2.4.2, can you check with ~2.4.3~ 2.4.4-beta? That one is not yet released but it will be quite soon.

UniqueActive commented 11 months ago

I am observing the same issue, both on on the last stable release and on 2.4.3-beta-DEBUG. Would be happy to test when you have a new version ready. :)