newhinton / Round-Sync

An android cloud file manager, powered by rclone. Visit https://roundsync.com for more information!
https://roundsync.com
GNU General Public License v3.0
1.3k stars 51 forks source link

"filename_encryption = false" seems not to be saved in rclone.conf #195

Open sebadamus opened 11 months ago

sebadamus commented 11 months ago

What version of Round Sync are you using (About -> App version)?

2.2.2

What is your Android version, phone model and manufacturer?

Example: Android 13, One UI 5.1, Samsung XForce-5

Which steps are required to reproduce this issue?

Create new remote
Select "Crypt" type
Name: TestName
Remote: myremoteftp:/rclone-crypt
Filename Encryption: OFF
Directory Name Encryption: NOT CHECKED
Password:  same configure and working with rclone-browser
Password2: same configure and working with rclone-browser
(I also tried toggling advanced options and typing .bin within the Suffix option and without any toggling advanced options.)

What is your configuration (rclone.conf)?

[eGeek-FTP]
type = ftp
host = myftp.somewhere
explicit_tls = false
user = myftpuser
rclone_remote_name = eGeek-FTP
pass = ThePass1
port = 21

[5d44cd8d-397c-4107-b79b-17f2b6a071e8]
type = alias
remote = /storage/emulated/0

[6517-7916]
type = alias
remote = /storage/6517-7916

[eGeek-FTP-crypt]
type = crypt
no_data_encryption = false
rclone_remote_name = eGeek-FTP-crypt
password = ThePass2
directory_name_encryption = false
password2 = TheSalt
remote = eGeek-FTP:/rclone-crypt
suffix = .bin

Does the same issue also occur when using the same configuration on a PC or in Termux?

On PC works just as it might be supposed to work, I mean filenames should be like "realfilename.jpg.bin" Tested on PC with RcloneBrowser 1.8 and rclone 1.6.5 same rclone.conf copied from RoundSync 2.2.2

When uploading with RoundSync 2.2.2 with this options from above, you get filenames encrypted without .bin extension. Seems the option its not passed to the rclone.conf and its left like without "filename_encryption = false" other options as far as I test are passed to the rclone.conf ok.

I test RoundSync 2.4.3-beta-DEBUG, and the problems seems to be resolved. Anyway, with this version... the first time you add a new crypt remote, you can see that "filename_encryption" option wont let you choose anything else that "standard". So you just add it this way and after creating it you edit the remote again and there the 3 options appears letting you choose "off"

What I havent test is re-importing a modified rclone.conf adding the "filename_encryption = false" manually... will try later!

sebadamus commented 11 months ago

OK, just tested reimporting RoundSync 2.2.2 config export with the manually added option and it works fine. But as soon as you edit any remote in the app it seems to rewrite the whole rclone.conf and again the "filename_encryption = off" wont be saved.

PS: excellent app you have createad Felix... really great, hope to donate some way soon.