Paginator - Githubissues

newism / symfony2-standard-template

2 stars 5 forks source link

Paginator #27

Open leevigraham opened 10 years ago

leevigraham commented 10 years ago

calculateFirstResultOffset()
getCurrentPageFirstResultOffset()
calculateLastResultOffset()
getCurrentPageLastResultOffset()

all need reworking. They are calculating wrong.

On a page with 0 results calculateFirstResultOffset returns 1.
getCurrentPageLastResultOffset doesn't take into consideration half responses on the last page.

This might be a good thing to write tests for.

leevigraham commented 10 years ago

Looking at this again the getCurrentPageFirstResultOffset and getCurrentPageLastResultOffset are used for the doctrine query and templates. Might need to split these out.