While QAing #8534 we found out the domestic employer guest mode experience had not been covered. This work shifts from using the Domestic Employer operating phase as a control, and looks at the industry id. There's probably a better way to go about this, see notes.
Shifted from checking the current operating phase to checking the industry-id in order to account for Guest Mode operating phases.
Steps to Test
see #8534 for detailed steps to test - The only addition is that a user in Guest Mode should experience the same behaviors.
Notes
In looking at this a little further, I stumbled across some logic in the roadmapBuilder.ts that I hadn't considered before. Specifically, thinking about how it adds foreign-business steps. Given the Domestic Employer work required creating a new roadmap section, this may not be enough control, but it did get me thinking that there might be a better way to handle these changes.
Code author checklist
[X] I have rebased this branch from the latest main branch
[X] I have performed a self-review of my code
[X] I have created and/or updated relevant documentation on the engineering documentation website
[X] I have not used any relative imports
[X] I have pruned any instances of unused code
[X] I have not added any markdown to labels, titles and button text in config
[X] If I added/updated any values in userData (including profileData, formationData etc), then I added a new migration file
[X] I have checked for and removed instances of unused config from CMS
[X] If I added any new collections to the CMS config, then I updated the search tool and cmsCollections.ts (see CMS Additions in Engineering Reference/FAQ on the engineering documentation site)
[X] I have updated relevant .env values in both .env-template and in Bitwarden
Description
While QAing #8534 we found out the domestic employer guest mode experience had not been covered. This work shifts from using the Domestic Employer operating phase as a control, and looks at the industry id. There's probably a better way to go about this, see notes.
Ticket
This pull request resolves #188193453.
Approach
Shifted from checking the current operating phase to checking the industry-id in order to account for Guest Mode operating phases.
Steps to Test
see #8534 for detailed steps to test - The only addition is that a user in Guest Mode should experience the same behaviors.
Notes
In looking at this a little further, I stumbled across some logic in the
roadmapBuilder.tsthat I hadn't considered before. Specifically, thinking about how it adds foreign-business steps. Given the Domestic Employer work required creating a new roadmap section, this may not be enough control, but it did get me thinking that there might be a better way to handle these changes.Code author checklist
userData(includingprofileData,formationDataetc), then I added a new migration filecmsCollections.ts(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).envvalues in both.env-templateand in Bitwarden