search

newjersey / njwds

NJ Web Design Standards
https://newjersey.github.io/njwds/
MIT License
9 stars 2 forks source link

chore: move pr check jobs to own workflow #15

Closed bodnarbm closed 1 year ago

bodnarbm commented 1 year ago

Summary

The current GitHub Actions workflow is triggering on PRs targeting the main branch, which causes gh pages to attempt to deploy each PR. This is problematic both for PRs from forks and dependabot, as those PRs will not have permissions to deploy to gh pages, and it would result in PRs that have not yet been approved to override the existing deployment on gh pages.

This change removes the pr trigger from the publish workflow and adds a new workflow for checking prs. Currently this only tests that the PR builds both the njwds assets and the associated docs (there are no current tests to run in addition).

Test Plan

This PR should serve as its own test.

namanaman commented 1 year ago

Looks good to me!

namanaman commented 1 year ago

@dsueltenfuss Just looping you in as an FYI since you work the most with the repo; but feel free to give any feedback

dsueltenfuss commented 1 year ago

This looks great!