newjersey / njwds

NJ Web Design Standards
https://newjersey.github.io/njwds/
MIT License
9 stars 2 forks source link

fix: copy missing uswds js files #17

Closed bodnarbm closed 1 year ago

bodnarbm commented 1 year ago

Summary

During the upgrade to uswds version 3.0.1 in 5ee0e83fbeab63ef5da9ba2204b6a00806045af0, we updated the source directories for images and fonts, but missed the javascript directory change. This is causing some components to not act correctly (for example the accordions at https://newjersey.github.io/njwds/components/detail/accordion--default.html stay fully expanded on load and cannot collapse).

Screen Shot 2022-09-23 at 1 29 04 PM

This applies the same fix from those directories to the js directory for uswds.

Test Plan

Run build locally and confirmed that the js files appear again in the dist folder.

I also ran npm run build-docs locally and opened the Borderless Accordion example (at build/components/detail/accordion--default.html), and made sure the accordions work again.

Screen Shot 2022-09-23 at 1 29 24 PM
namanaman commented 1 year ago

Nice catch!