newjersey / taxation-mef-viewer

Fork of betson/irs-efile-viewer for DOT use
MIT License
0 stars 0 forks source link

[SHIP] Add headers for Sample1120 to allow MeF viewer to parse it #9

Closed jachan closed 2 months ago

jachan commented 2 months ago

Description

Ticket link here

Prototype works with externally hosted file, 1120 form fails to load when user uploads a file. Examining form_template.xml to see if additional modifications there are needed.

Approach

Root cause was not an issue with the MeF Viewer but with the input file itself. The header of the auto-generated 1120 did not contain xmlns:xsi and xsi:schemaLocation attributes, which caused the XPATH transforms to fail because it was not able to transfer elements from the inputDOM to the templateDOM. Relevant code for XPATH transform

Steps to test

Tested this by hosting the viewer locally and verifying that I could upload files to localSessionStorage and view the resulting 1120.

Notes

This brings up a good question -- which is to validate whether the files that DORES provides users have this header on the XML or not. I have been auto-generating the Sample1120 using the IRS' Schema, but the Schema does not specify these headers. We would expect it to contain all these headers but we should validate this.