search

newlandsvalley / chord-editor

UI for generating simple chord diagrams for guitar, bass and piano
MIT License
9 stars 2 forks source link

Feature Request: Tenor Banjo #15

Open jgarte opened 1 year ago

jgarte commented 1 year ago

Hi,

The difference between a tenor banjo and a tenor guitar is just the timbre or sound (e.g. a different MIDI instrument).

How should we add this and introduce the tenor banjo?

newlandsvalley commented 1 year ago

Well I've always considered sounding the instrument as an optional extra - originally Sturla didn't even want this feature and I added it simply because I could. And many of the MIDI instruments sound pretty terrible anyway, although I think the banjo sounds OK.

So, I have no great desire to add this feature and I feel it will complicate the UI for very little gain. We wouldn't want all that extra copying to create a new instrument which is virtually identical. The only thing I can think of is to call it the Tenor Guitar / Banjo and then alternate between the two sounds when the user plays it.

jgarte commented 1 year ago

I agree that we shouldn't copy code for this.

I was thinking of something with a configurable design. Not sure yet how to achieve that though.

Toggling between the two timbres sounds like one approach that could work.