search

newlandsvalley / chord-editor

UI for generating simple chord diagrams for guitar, bass and piano
MIT License
10 stars 3 forks source link

Refreshing the Tenor Guitar page errors #8

Closed newlandsvalley closed 2 years ago

newlandsvalley commented 2 years ago

I think this is to do with translation to and fro between the URI string component and the FrettedInstrumentExample data type. I think we need to decide on whether or not the URI component is tenorGuitar or tenorguitar. I suspect it will be a lot more straightforward to change it to the latter.

jgarte commented 2 years ago

Why do you think the latter will be more straightforward? Just curious

newlandsvalley commented 2 years ago

Just laziness - I'm guessing you can probably just use toLower when converting from the Example type.

newlandsvalley commented 2 years ago

Fixed by bd4d243f26b13b8f3397b16d428680cb116f060f