search

newlandsvalley / elm-comidi

MIDI parser in pure elm
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Change to elm-community/parser-combinators package #5

Open stil4m opened 7 years ago

stil4m commented 7 years ago

Use elm-community/parser-combinators. This is the continuation of the package that Bogdanp created (which is no longer maintained).

rhofour commented 6 years ago

Ping. This looks worthwhile.

newlandsvalley commented 6 years ago

Yes - the reason I'm resisting is that there is an elephant in the room. Months ago now, Evan stated that he was removing $ (and hence <$, $> and <$>) from the language in 0.19. This, of course, emasculates an applicative parser and was the reason Bogdan stopped supporting elm-combine in the first place. Evan has since stated he didn't like even its existence in elm-community. So I decided to wait until 0.19 is released and see how Mats deals with it.

stil4m commented 6 years ago

I missed the discussion around the removal of $ from the language and the existence of parser combinators from elm-community. Haven't been active in the community as much as I hoped for the last months.

Based on this I'm planning to discuss the continuation of parser-combinators with the community group. As for now, maybe look at elm-tools/parser, it may be still wise to replace the deprecated package by Bogdan (while it will not be upgraded to 0.19.

rhofour commented 6 years ago

I'm also not so involved in the community. Since everything works for-now it might make sense to just hold off on changing the parser until elm 0.19 when we know what things will look like.

newlandsvalley commented 6 years ago

If you're interested, here's the original thread about removing $ - https://groups.google.com/forum/#!topic/elm-dev/0AHSnDdkSkQ. I can't find the thread (possibly on Slack?) where Evan was questioning the reasons for continuing to support some of the community packages. By the way, @stil4m, very many thanks for preparing the PR - I don't wish to sound ungrateful.

newlandsvalley commented 6 years ago

Found it. Here's the discussion about possible deprecation of elm-community libraries for 0.19 - https://github.com/elm-community/Manifesto/issues/82.

lassik commented 5 years ago

Elm 0.19 has now been out for a while. Is anyone here up to date with the parsing situation? Would be very nice to upgrade elm-comidi if it can be done with reasonable effort.

lassik commented 5 years ago

Here's an actively developed fork of parser-combinators upgraded for Elm 0.19: https://github.com/andre-dietrich/parser-combinators.

newlandsvalley commented 5 years ago

I have no real inclination to maintain elm-comidi beyond Elm 0.18 (having moved my codebase over to PureScript). I would be happy to hand over maintenance if someone wants to take it on.