search

newlandsvalley / elm-comidi

MIDI parser in pure elm
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

Change payload type of SequencerSpecific messages #9

Closed newlandsvalley closed 6 years ago

newlandsvalley commented 6 years ago

from String to List Int

rhofour commented 6 years ago

Sounds good to me. I'd suggest:

type alias Byte = Int

Then using List Byte instead so the intention is more clear. That's what I've been doing in my generate code.

newlandsvalley commented 6 years ago

OK - good suggestion. and use this for SysEx, SequencerSpecific and Unspecified?

rhofour commented 6 years ago

Yeah, I think we should use it anywhere where we're representing bytes with ints. If you look at my https://github.com/rhofour/elm-comidi/blob/generate/src/Midi/Types.elm you'll see I've added a bunch of other type aliases to make things more clear.

newlandsvalley commented 6 years ago

Fixed via c26e51b981a7193b2b329a1d70de398dbc1cd29b.