search

newlandsvalley / purescript-midi

MIDI and Web MIDI support
MIT License
10 stars 1 forks source link

Check the Gleitzman instrument names against the different providers #13

Closed newlandsvalley closed 2 years ago

newlandsvalley commented 2 years ago

I've just noticed that the Gleitzman MIDI instrument names differ across the different soundfont providers that he uses. If we want to allow the user to choose between these providers in the soundfonts module, we'll need first to sort this out.

newlandsvalley commented 2 years ago

OK, instrument names in the Gleitzman site are identical across the three main providers (FluidR3_GM, MusyngKite and FatBoy) and the names are saved redundantly against each provider. So we don't have a problem. Just don't use Tabla which just uses a single synth_drum instrument. We should probably just document the gleitzmanName function to indicate where the names come from.

newlandsvalley commented 2 years ago

Fixed by 1c13630ceb2c6ea1b28f04bb2469ce987c5de335