newlandsvalley / purescript-soundfonts

Access to pre-rendered General MIDI instrument soundfonts
MIT License
10 stars 1 forks source link

toMelody should allow the MIDI phrase length to be set #3

Closed newlandsvalley closed 5 years ago

newlandsvalley commented 6 years ago

Audio.SoundFont.Melody.Maker toMelody has the signature:

   toMelody :: Midi.Recording -> Melody

with a preset phrase length for the Melody of 0.6s.

we should instead use

   toMelody :: Number -> Midi.Recording -> Melody

to allow the user to specify the phrase length. This influences the responsiveness of 'play' buttons in audio players, which can only interrupt the melody after each phrase has played.

newlandsvalley commented 5 years ago

Fixed by adding toMelody_ with this signature,