newlinedotco / yelp-clone

Yelp clone for blog post at fullstackreact.com
https://www.fullstackreact.com/articles/react-tutorial-cloning-yelp/
37 stars 15 forks source link

missing a param in the tutorial #3

Closed KevinColemanInc closed 8 years ago

KevinColemanInc commented 8 years ago

I think instead of

ReactDOM.render(
  <App history={browserHistory} />, mountNode);

it needs to be

ReactDOM.render(
  <App history={browserHistory} routes={routes} />, mountNode);

image

auser commented 8 years ago

Ah thanks for the bug report @KevinColemanInc. We don't have routes yet there in the post. Think we should create a dummy route at that point or do you think it's resolved later in the post?

KevinColemanInc commented 8 years ago

@auser if you scroll up a bit:

image

I think your requiring the router to be passed in, but then in your example code when you scroll down (my initial post), you aren't passing it in, so it wasn't working for me.