search

newpavlov / rosbag-rs

Reading rosbag files in pure Rust
Apache License 2.0
9 stars 5 forks source link

Topic missing on connection's header generate error #6

Closed rlamarche closed 5 months ago

rlamarche commented 5 months ago

On ROS Noetic rosbags, the header topic is missing in connection's headers.

I don't know if it's related to https://answers.ros.org/question/266967/why-does-rosbag_storage-add-topic-to-the-connection-header/ but this MR seems to fix the problem.

Note that in this library, the header is get from the record and not the connection's headers :

https://github.com/swri-robotics/bag-reader-java/blob/master/src/main/java/com/github/swrirobotics/bags/reader/records/Connection.java#L54C9-L54C16

newpavlov commented 5 months ago

Sigh... It's what we get when a format does not have a proper specification.

Looking at this issue it looks like topic in connection record is a legacy leftover.

newpavlov commented 5 months ago

Thank you! This fix is released in v0.6.3.

rlamarche commented 5 months ago

And thanks to you too !