newrelic-experimental / gitlab

Gitlab exporters to send metrics,logs,traces to New Relic
9 stars 6 forks source link

Service.Name not set correctly for Jobs #11

Closed OllieDavies closed 1 year ago

OllieDavies commented 1 year ago

GitLab Jobs exported via new-relic-metrics-exporter all contain the string "gitlab-exporter" in Service.Name instead of being the project name.

Looks like get_jobs never overrides GLAB_SERVICE_NAME like other methods in get_resources.py do.

Happy to raise a PR if preferred 🙂

dpacheconr commented 1 year ago

fixed in 1.03 thanks for reporting @OllieDavies

OllieDavies commented 1 year ago

That's fixed it, thanks @dpacheconr 🎉