search

newrelic-experimental / newrelic-eks-blueprints-addon

This repository contains the source code for the New Relic AddOn for AWS EKS Blueprints. EKS Blueprints is a CDK construct that makes it easy for customers to configure and deploy New Relic's Kubernetes integration as part of an EKS Blueprint cluster on Amazon EKS
Apache License 2.0
3 stars 1 forks source link

[TODO] Make Pixie keys optional in AWS Secret #9

Closed bpschmitt closed 2 years ago

bpschmitt commented 2 years ago

Summary

Currently, all JSON keys below are required to be defined if using AWS Secrets Manager.

{
  nrLicenseKey: "some key",
  pixieDeployKey: "some key",
  pixieApiKey: "some key"
}

nrLicenseKey will always be required, however, the Pixie keys could be optional and therefore, not defined by the user.

Desired Behavior

This should work as an AWS Secret

{
  nrLicenseKey: "some key"
}

Possible Solution

Current workaround:


{
  nrLicenseKey: "some key",
  pixieDeployKey: "",
  pixieApiKey: ""
}
bpschmitt commented 2 years ago

Fixed in https://github.com/newrelic-experimental/newrelic-eks-blueprints-addon/commit/048bd8283e58426f1a81d95a528cecd152835f48.