newrelic-experimental / newrelic-nextjs-integration

NewRelic Browser and APM agent NextJs integration (front and back-end respectively)

Apache License 2.0

27 stars 22 forks source link

(feat) add typescript types to New Relic related components #12

Closed christianvuerings closed 1 year ago

christianvuerings commented 1 year ago

Changes

Fixes 2 TypeScript errors in pages/_document.tsx

Notes

I tried including @types/newrelic but those seem outdated since newrelic.agent and the allowTransactionlessInjection option on getBrowserTimingHeader do not yet exist.

CLAassistant commented 1 year ago

All committers have signed the CLA.

christianvuerings commented 1 year ago

@matewilk would you be able to take a look?

matewilk commented 1 year ago

Hey @christianvuerings,

Thanks for the PR,

I'll take a look as soon as I can, hopefully by the end of the week. I'll also include some global type definitions for the NR Browser Agent methods.

matewilk commented 1 year ago

Hey @christianvuerings,

I've added the @types/newrelic package and overrode some methods (the package is out of date as you've mentioned so it's a temp solution for the time being) I also added types for the New Relic browser agent under /types/global.d.ts

Let me know if you need anything else before I merge.

christianvuerings commented 1 year ago

Looks great, thank you!