Set default value of `NRLoggingEnabled` Parameter to True

AkhilReddyS-NR commented 2 months ago

Changed the default value of the Parameter NRLoggingEnabled to True
This change eases the deployment process for customers by removing the need to manually configure logging .
Details of testing done Manual Testing:
- Manually tested the Lambda function with the loggingEnabled variable set to true.
- Verified that logs are being forwarded to NewRelic.
- Confirmed the function's behavior and performance with logging enabled and logging disabled.
- Ensured no unintended behavior or issues were introduced. Automated Testing:
  - Executed all the test cases present in the tests folder of the repository.
  - Ensured that all tests passed successfully without any errors or failures.
Jira story - NR-303954

CLAassistant commented 2 months ago

All committers have signed the CLA.

maya-jha commented 2 months ago

Can you add details of testing done.
Also add the Jira/github issue id.

AkhilReddyS-NR commented 2 months ago

Can you add details of testing done.

Also add the Jira/github issue id.

Added the details of testing and Jira Id to the desription.

maya-jha commented 2 months ago

Can you update README.md and remove


* To set `LOGGING_ENABLED`: `sam build ... --parameter-overrides 'ParameterKey=NRLoggingEnabled,ParameterValue=True'`
* To set `LOGGING_ENABLED`: `export LOGGING_ENABLED=True` (prior to deploy)```

newrelic / aws-log-ingestion

Set default value of `NRLoggingEnabled` Parameter to True #122