newrelic / centurion

A mass deployment tool for Docker fleets
MIT License
1.76k stars 113 forks source link

deploy:repair doesn't utilize custom health check method #179

Open intjonathan opened 7 years ago

intjonathan commented 7 years ago

The deploy:repair task is not only undocumented, but uses a naive invocation of #http_status_ok?:

unless method(:http_status_ok?).call(server, port, fetch(:status_endpoint, '/'))

Users with custom health checks can't avail themselves of this useful task.

relistan commented 7 years ago

😞 Good catch