search

newrelic / csec-node-agent

Repository for new relic node security agent
Other
2 stars 7 forks source link

@newrelic/security-agent v1.1.0 grpc instrumentation breaks New Relic agent instrumentation #192

Closed bizob2828 closed 3 months ago

bizob2828 commented 3 months ago

Steps to Reproduce

  1. Clone https://github.com/newrelic/node-newrelic
  2. npm ci
  3. NEW_RELIC_SECURITY_AGENT_ENABLED=true npm run versioned:internal:major grpc-js

Expected Behavior

All agent instrumentation versioned tests still pass with security agent.

Additional context

It looks like the instrumentation in security agent is stomping on the Node.js agent. We request that you back out grpc-js instrumentation and re-release until you can fix this bug.

sumitsuthar commented 3 months ago

Here is the link of versioned test. https://github.com/k2io/node-newrelic-fork/actions/runs/8372881827 Drafted PR to update @newrelic/security-agent. https://github.com/newrelic/node-newrelic/pull/2092