search

newrelic / docs-website

Source code for @newrelic docs. We welcome pull requests and questions on our docs!
https://docs.newrelic.com
Other
175 stars 1.27k forks source link

chore: Add configuration for adding labels to agent-forwarded logs. #19213

Closed jaffinito closed 5 days ago

jaffinito commented 2 weeks ago

Give us some context

Updates the .NET Agent config doc to include configuration for the new feature adding labels to agent-forwarded logs.

github-actions[bot] commented 2 weeks ago

Hi @jaffinito 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

netlify[bot] commented 2 weeks ago

Deploy Preview for docs-website-netlify ready!

Name Link
Latest commit 06ed9fbcfa35aa214b5d94b9309506c0d4dd7f60
Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/673dc6cfab95d80008e989a2
Deploy Preview https://deploy-preview-19213--docs-website-netlify.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaffinito commented 2 weeks ago

Edits look great!

I don't have a CLA button. I signed it a long time ago.

nbaenam commented 1 week ago

Edits look great!

I don't have a CLA button. I signed it a long time ago.

Hi @jaffinito, can you try this, please? https://cla-assistant.io/newrelic/docs-website?pullRequest=19213. We can't merge this PR without signing the CLA. It's a required check and it's not green. Maybe you need to re-sign it.

jaffinito commented 1 week ago

When I load that link, I see my details and it shows I agreed to it already: image

Are you sure that check is working? I never had to do this with all my other PRs.

CLAassistant commented 6 days ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: adutta-newrelic
:x: nbaenam

nbaenam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

adutta-newrelic commented 5 days ago

Closing this PR as there is a conflict with the CLI, created a new https://github.com/newrelic/docs-website/pull/19341