newrelic / docs-website

Source code for @newrelic docs. We welcome pull requests and questions on our docs!
https://docs.newrelic.com
Other
174 stars 1.26k forks source link

[Machine Translation] Machine translate all relevant files #5162

Closed roadlittledawn closed 2 years ago

roadlittledawn commented 2 years ago

Summary

Once all the work is done to set up machine translation and the feature/machine-translation branch is merged into develop, we want to:

Relevant files

Script

Normally, a PR will contain a set of files, and that triggers the first workflow to look at that set of files and queue them up for translation. Since we want this to run for some subset of files manually, we will need a custom script. The script will need to: - identify all non-human translate pages -- pages we want to machine translate - filter out exclusions mentioned above - submit records to database directly. This criteria isn't the only way to do this, but is the simplest imo. We can also test this locally just to be sure.

Acceptance criteria

github-actions[bot] commented 2 years ago

Hi @roadlittledawn 👋 Thank you for filing an issue! We'll triage your issue and let you know if we have questions, and then route it to the appropriate team so we can get it solved.

clarkmcadoo commented 2 years ago

@roadlittledawn regarding the exclusions we want to add, will this be for all various locales or just one in particular (say ja-JP for now 😄 )

jmiraNR commented 2 years ago

Hello, Could these pages be excluded from the Machine translation workflow? Data privacy: https://docs.newrelic.com/docs/security/security-privacy/data-privacy/ Security compliance: https://docs.newrelic.com/docs/security/security-privacy/compliance/ Thank you.

clarkmcadoo commented 2 years ago

@zstix -- leaving this in the "In Review" column until the PR with all of the Machine Translations have been completed, @nr-kkenney came up with the plan and knows what's going on with that 🙏 👍

roadlittledawn commented 2 years ago

update from workflow run this morning:

moonlight-komorebi commented 2 years ago

going to close this ticket and track the follow up work per clinton's last comment in https://github.com/newrelic/docs-website/issues/5348.

i think this is fair since this update does what we want it to do and does work, its just that we hit an edge case for our overall process -- and not specifically this effort -- that we didn't factor in.