search

newrelic / elixir_agent

New Relic's Open Source Elixir Agent
https://hex.pm/packages/new_relic_agent
Apache License 2.0
254 stars 97 forks source link

Aggregate dimensional metrics #408

Closed XiXiaPdx closed 1 year ago

XiXiaPdx commented 1 year ago

This is a stab to build off of this PR #376

Looking at the original comments by Vince, I think one missing piece was aggregating the dimensional metrics during the 5 second reporting interval? I took a stab at it.@tpitale , if you have some time, love to hear your thoughts on this. I know @mattbaker is interested in getting it over the finish line.

Also, I think that common block is accurate for count and summary - https://docs.newrelic.com/docs/data-apis/ingest-apis/metric-api/report-metrics-metric-api/#optional-map-attributes.

But for gauge, it appears the interval.ms value isn't required. It probably does no harm 😄 As an aside, the old NR Telemetry SDK specs also show gauge without interval.ms

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

tpitale commented 1 year ago

👀

tpitale commented 1 year ago

I have signed the CLA 👎🏼 I must have done it from my NR laptop 🙃

XiXiaPdx commented 1 year ago

I was able to send count and gauge to NR. https://staging.onenr.io/0oqQalyXGj1

But I'm having issues with summary and it is not clear to me why. I started a thread in help-metric

XiXiaPdx commented 1 year ago

confirmed count gauge and summary are all making it to NR. https://staging.onenr.io/0kERzx3KAQr