newrelic / gatsby-plugin-newrelic

A Gatsby plugin for instrumenting your site with New Relic's Browser Agent
https://opensource.newrelic.com/projects/newrelic/gatsby-plugin-newrelic
Apache License 2.0
8 stars 19 forks source link

Support gatsby 4 #42

Closed herecydev closed 2 years ago

herecydev commented 3 years ago

Acceptance Criteria

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

herecydev commented 2 years ago

It's been a month and literally no movement on this? @devfreddy

jpvajda commented 2 years ago

@herecydev sorry for the delay, let me review this out for you.

jpvajda commented 2 years ago

@herecydev have you validated this change to plugin solves your problem reported in the linked issue? It's a very simple change but I'm curious how to best test it with your site to ensure this will all that is required to enable the plugin to support Gatsby 4.

A way to test would be to start two new sites, one 3.x and one 4.x and make sure both continue to work. we'd probably need to release an alpha version of this to NPM to test it though

herecydev commented 2 years ago

I haven't, I did check against what's changed and couldn't find anything relevant. However if you did want to push an alpha out I would happily confirm that it solves the issues and continues to function. I know that it still works because I do already use this against Gatsby 4. It just throws warnings..

jpvajda commented 2 years ago

@herecydev much of our team is on holiday leave at the moment so we were going to look at creating an alpha package on NPM in early January for the plugin, would that work for you?

jpvajda commented 2 years ago

For context I added some Acceptance Criteria so the team knows the next steps on this PR @zstix

herecydev commented 2 years ago

@jpvajda yer that's fine for me

jpvajda commented 2 years ago

I've reached out to @devfreddy on the process to release an alpha version of this package on NPM.

jpvajda commented 2 years ago

closing this in favor of this PR https://github.com/newrelic/gatsby-plugin-newrelic/pull/45