newrelic / go-agent

New Relic Go Agent
Apache License 2.0
764 stars 294 forks source link

Stage securityagent integration for release #737

Closed nr-swilloughby closed 1 year ago

nr-swilloughby commented 1 year ago

This merges the nrsecurityagent into the develop branch to complete testing in preparation for the next release of the go agent.

codecov-commenter commented 1 year ago

Codecov Report

Merging #737 (251956c) into develop (53cd82a) will decrease coverage by 11.83%. The diff coverage is 51.91%.

@@             Coverage Diff              @@
##           develop     #737       +/-   ##
============================================
- Coverage    93.70%   81.88%   -11.83%     
============================================
  Files           41      123       +82     
  Lines         2003    11453     +9450     
============================================
+ Hits          1877     9378     +7501     
- Misses          97     1831     +1734     
- Partials        29      244      +215     
Impacted Files Coverage Δ
v3/integrations/nrgin/nrgin.go 85.29% <0.00%> (-8.26%) :arrow_down:
v3/newrelic/instrumentation.go 79.71% <0.00%> (ø)
v3/newrelic/internal_app.go 38.92% <0.00%> (ø)
v3/newrelic/internal_txn.go 91.12% <ø> (ø)
v3/newrelic/secure_agent.go 13.79% <13.79%> (ø)
v3/integrations/nrgrpc/nrgrpc_client.go 82.43% <23.52%> (-17.57%) :arrow_down:
v3/newrelic/sql_driver.go 65.10% <51.35%> (ø)
v3/newrelic/application.go 80.00% <57.14%> (ø)
v3/newrelic/transaction.go 70.29% <62.65%> (ø)
v3/newrelic/tracing.go 96.44% <66.66%> (ø)
... and 4 more

... and 94 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

iamemilio commented 1 year ago

I am a little concerned about the logrus test failing too

nr-swilloughby commented 1 year ago

Thanks for catching those vestiges of the prerelease code still in there. They'd have been cleaned up during release prep but it's better to get them now.