search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
764 stars 294 forks source link

Fix for data race with NewGoroutine #754

Closed aayush-ap closed 1 year ago

aayush-ap commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #754 (eaf1ae6) into develop (182f9e3) will decrease coverage by 0.09%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #754      +/-   ##
===========================================
- Coverage    82.40%   82.31%   -0.09%     
===========================================
  Files          136      134       -2     
  Lines        12177    12111      -66     
===========================================
- Hits         10034     9969      -65     
+ Misses        1884     1882       -2     
- Partials       259      260       +1
Impacted Files Coverage Δ
v3/newrelic/internal_txn.go 90.94% <100.00%> (+0.08%) :arrow_up:
v3/newrelic/transaction.go 70.29% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nr-swilloughby commented 1 year ago

(...and verify that the implementation of the above fully resolves the race condition issue)