newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 296 forks source link

sqlOperations from private to public #766

Open kazu697 opened 1 year ago

kazu697 commented 1 year ago

Summary

In nrpq.go, where the Postgres DatastoreSegment is being retrieved, the execution of the Truncate query in Postgres is displayed as "Other." The reason for this is that the query named "Truncate" is not registered in sqlOperations within sqlparse.go.

https://github.com/newrelic/go-agent/blob/046b4fc116adac2b4dec4d691b61a25b80488fc2/v3/newrelic/sqlparse/sqlparse.go#L27-L42

Desired Behaviour

it would allow the addition of keys within the project code, thereby enabling the display of queries such as Truncate in DatastoreSegment.

Possible Solution

I would like to propose a change in the visibility of sqlOperations from private to public.