search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 296 forks source link

(WIP) FastHTTP Integration #774

Closed mirackara closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@0afb8ac). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #774   +/-   ##
==========================================
  Coverage           ?   91.93%           
==========================================
  Files              ?       41           
  Lines              ?     2171           
  Branches           ?        0           
==========================================
  Hits               ?     1996           
  Misses             ?      136           
  Partials           ?       39

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

iamemilio commented 1 year ago

If you're going to wrap the client, then you should provide a wrapped function for each method of the client object, even if they are self referential https://pkg.go.dev/github.com/valyala/fasthttp#Client. Why not provide a wrapper for DoDeadline, Do Redirects.... etc?

iamemilio commented 1 year ago

Over all, this looks really good :)

Everything seems to be working as expected and I like the user experience much better of this version

nr-swilloughby commented 1 year ago

I'll open a bug fix for this.