newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 296 forks source link

chore: add logs-in-context example with logrus #778

Closed Julien4218 closed 1 year ago

Julien4218 commented 1 year ago

Details

This is a variation of the existing example for http-server, adding the specific steps to enable logs-in-context with distributed tracing.

image

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@d59f46c). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #778   +/-   ##
==========================================
  Coverage           ?   81.68%           
==========================================
  Files              ?      134           
  Lines              ?    12248           
  Branches           ?        0           
==========================================
  Hits               ?    10005           
  Misses             ?     1966           
  Partials           ?      277           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

iamemilio commented 1 year ago

rather than contribute this to v3/examples I think this would be a better fit for v3/integrations/logcontext-v2/nrlogrus/examples. Would you mind moving the file there? Thanks for contributing though, we are always happy to have more examples.

Julien4218 commented 1 year ago

rather than contribute this to v3/examples I think this would be a better fit for v3/integrations/logcontext-v2/nrlogrus/examples. Would you mind moving the file there? Thanks for contributing though, we are always happy to have more examples.

Sounds good, done.

iamemilio commented 1 year ago

Once you sign the CLA we can merge this.

Julien4218 commented 1 year ago

Once you sign the CLA we can merge this.

Done, thank you.