newrelic / go-agent

New Relic Go Agent
Apache License 2.0
762 stars 294 forks source link

Fix for out of memory error with request body #806

Closed aayush-ap closed 9 months ago

aayush-ap commented 10 months ago

Fix for out-of-memory error with request body

codecov-commenter commented 10 months ago

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (a1142ca) 81.10% compared to head (9cfa052) 80.27%. Report is 5 commits behind head on develop.

Files Patch % Lines
v3/integrations/nrmicro/nrmicro.go 7.31% 36 Missing and 2 partials :warning:
v3/newrelic/secure_agent.go 0.00% 34 Missing :warning:
v3/newrelic/transaction.go 12.50% 13 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #806 +/- ## =========================================== - Coverage 81.10% 80.27% -0.83% =========================================== Files 136 134 -2 Lines 12393 12328 -65 =========================================== - Hits 10051 9896 -155 - Misses 2062 2150 +88 - Partials 280 282 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mirackara commented 10 months ago

@aayush-ap It looks like this change also breaks the nrmicro and nrgrpc integrations (You can see more details in the GHA test suite for those two tests respectively. Once these are fixed, this looks good to merge :)

aayush-ap commented 10 months ago

@mirackara Please verify with latest changes