search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
762 stars 294 forks source link

Error Expected Bug #815

Closed iamemilio closed 10 months ago

iamemilio commented 10 months ago

The attribute error.expected should be a boolean, not a string. It is also good practice to use a constant value for the key.

Links

Details

codecov-commenter commented 10 months ago

Codecov Report

Merging #815 (1f34e2c) into develop (a1142ca) will decrease coverage by 0.26%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #815      +/-   ##
===========================================
- Coverage    81.10%   80.84%   -0.26%     
===========================================
  Files          136      133       -3     
  Lines        12393    12203     -190     
===========================================
- Hits         10051     9866     -185     
+ Misses        2062     2059       -3     
+ Partials       280      278       -2
Files Coverage Δ
v3/newrelic/error_events.go 93.61% <0.00%> (ø)

... and 8 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!