search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
762 stars 294 forks source link

feat instrument pgx CopyFrom #826

Open vinicius-batista opened 9 months ago

vinicius-batista commented 9 months ago

Links

Closes #825

Details

The implementation and tests was simple but I have a problem running tests when snapshot was already created. The current installed version from pgsnap fails when read CopyData from snapshot. At pgsnap's latest version CopyData and other messages were implemented but pgproto is failing to unmarshal CopyInResponse message.

I don't know how to proceed with this implementation as some tests are failing due to external dependencies.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

vinicius-batista commented 9 months ago

@iamemilio

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d752b7e) 80.06% compared to head (dc1ed85) 80.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #826 +/- ## =========================================== + Coverage 80.06% 80.37% +0.30% =========================================== Files 136 138 +2 Lines 12358 12489 +131 =========================================== + Hits 9895 10038 +143 + Misses 2180 2169 -11 + Partials 283 282 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nr-swilloughby commented 9 months ago

Thanks for your PR. We'll review it.