search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 296 forks source link

potential bug in newAppRun #918

Closed rittneje closed 4 months ago

rittneje commented 5 months ago

I came across the following code while trying to diagnose an oddity we are seeing with "expected status codes".

https://github.com/newrelic/go-agent/blob/424d17590487f6633a2edd5fc272737e46355900/v3/newrelic/app_run.go#L102-L108

Should that instead say run.Config.ErrorCollector.ExpectStatusCodes != nil?

iamemilio commented 5 months ago

Seems like a likely bug, we will make a ticket for it.

mirackara commented 4 months ago

Released fix with #924. Closing this out for now!