search

newrelic / go-agent

New Relic Go Agent
Apache License 2.0
775 stars 295 forks source link

remove all extraneous version constraints #940

Closed rittneje closed 3 months ago

rittneje commented 3 months ago

Fixes #939.

As per the README, Go 1.18+ is already required. Thus version constraints for 1.9 and 1.10 are unnecessary. (And these currently cause issues with 1.23rc2 due to https://github.com/golang/go/issues/68658.)

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

iamemilio commented 3 months ago

Hey @rittneje, can you rebase on develop. This commit is pulling in a lot of excess.

iamemilio commented 3 months ago

https://github.com/newrelic/go-agent/pull/941

rittneje commented 3 months ago

@iamemilio done

iamemilio commented 3 months ago

It looks like there is a stray commit still attached. Is it ok if we use this pull request containing your commit: https://github.com/newrelic/go-agent/pull/941? You are still credited on the commit, it just also lets me run it along side changes I just made to the test suite so that we can verify that go1.23rc runs as expected

iamemilio commented 3 months ago

Oh, I am just noticing now that the protobuff changes went into master instead of develop, and that is whats causing this

iamemilio commented 3 months ago

I can merge this here then, and I will rebase my commit on top.

iamemilio commented 3 months ago

Thanks @rittneje

gunturaf commented 3 months ago

Hi @iamemilio sorry for tagging you, I think the commit https://github.com/newrelic/go-agent/pull/940/commits/0fb9108c9779ee409fc9251170e3a29e7a338c1d broke the deps.

This is an excerpt of what I got:

../file.go:6:2: github.com/newrelic/go-agent/v3@v3.34.0 requires
    google.golang.org/protobuf@v1.5.3: reading google.golang.org/protobuf/go.mod at revision v1.5.3: unknown revision v1.5.3

This page https://pkg.go.dev/google.golang.org/protobuf?tab=versions shows that v1.5.3 is nonexistent. We may replace it with v1.34.1 (it seems we can't replace with the latest tag because it requires us to bump minimum go version to 1.20)

gunturaf commented 3 months ago

I've made a PR that might resolve that, please help review it https://github.com/newrelic/go-agent/pull/948 :)