search

newrelic / helm-charts

Helm charts for New Relic applications
Apache License 2.0
95 stars 201 forks source link

[newrelic/helm-charts] Support sha256 for NewRelic Prometheus Configurator #1069

Open quayly opened 1 year ago

quayly commented 1 year ago

Support sha256 for NewRelic Prometheus Configurator

In our environment, we use binary auth with the sha256 to verify the images for deployment

For example, in our yaml file, we have something like: images: configurator: registry: "http://myurl/to/registry" repository: newrelic/newrelic-prometheus-configurator pullPolicy: IfNotPresent tag: "1.2.0" version: "1.2.0"

This works for environment that doesn't use binary auth.

However, for environment that uses binary auth, we have the following, it would fail.: images: configurator: registry: "http://myurl/to/registry" repository: newrelic/newrelic-prometheus-configurator pullPolicy: IfNotPresent tag: "1.2.0" version: "1.2.0" sha: 3d939e773cbed8fcff9d59f22b4efa4edc0f89daeedda946acab904ca6a12345

Is it possible to have the helm chart to check to see if the sha is available and use it? Thanks

workato-integration[bot] commented 1 year ago

https://issues.newrelic.com/browse/NEWRELIC-8181

workato-integration[bot] commented 1 year ago

Jira CommentId: 186738 Commented by epai:

this is a feature request. we would need to change our charts to make sha configurable at the very least and potentially add additional image signing in our build/release steps to support this. the work should be straight forward but we should still scope and prioritize it